Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove calls to Step.closeout in tests #8428

Merged
merged 2 commits into from
May 9, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Apr 19, 2024

Several tests call Step.closeout with no arguments. This results in a single call to gc.collect (since both to_close and to_del were not provided).

This PR removes the calls to Step.closeout. These were not replaced with calls to gc.collect (as python should manage that itself). Removing the usage in the tests will allow Step.closeout to be removed (as it is otherwise unused).

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@braingram braingram marked this pull request as ready for review April 19, 2024 17:31
@braingram braingram requested a review from a team as a code owner April 19, 2024 17:31
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.93%. Comparing base (6580914) to head (781e0e0).
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8428      +/-   ##
==========================================
+ Coverage   56.38%   57.93%   +1.55%     
==========================================
  Files         387      387              
  Lines       38716    38839     +123     
==========================================
+ Hits        21830    22502     +672     
+ Misses      16886    16337     -549     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbushouse hbushouse added this to the Build 11.0 milestone May 9, 2024
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

@braingram braingram merged commit b37c815 into spacetelescope:master May 9, 2024
27 of 28 checks passed
@braingram braingram deleted the no_closeout branch May 9, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants