Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fixture for closedfile regtest #8387

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Mar 25, 2024

While updating fixtures in #8327 the run_image3_closedfile fixture was changed from:

def run_image3_closedfile(rtdata, jail):

to

def run_image3_closedfile(rtdata_module):

The use of rtdata_module change the directory where the fixture files are written. The files are written to a directory path ending in .../test_nircam_image_rtdata_module0
However test_image3_closedfile uses a different directory to check for the files (due to the conflicting rtdata fixture):

@pytest.mark.bigdata
def test_image3_closedfile(run_image3_closedfile, rtdata, fitsdiff_default_kwargs):

It checks a directory with a path ending in: .../test_image3_closedfile0

This PR uses rtdata instead to allow the paths to match.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.66%. Comparing base (2fb073e) to head (fa71e19).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8387      +/-   ##
==========================================
+ Coverage   75.31%   75.66%   +0.34%     
==========================================
  Files         474      476       +2     
  Lines       38965    39434     +469     
==========================================
+ Hits        29345    29836     +491     
+ Misses       9620     9598      -22     
Flag Coverage Δ *Carryforward flag
nightly 77.63% <ø> (+0.30%) ⬆️ Carriedforward from 2fb073e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review March 26, 2024 14:51
@braingram braingram requested a review from a team as a code owner March 26, 2024 14:51
@hbushouse hbushouse merged commit ec0f0ed into spacetelescope:master Mar 27, 2024
28 of 29 checks passed
@braingram braingram deleted the closedfile_regtest branch March 27, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants