Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove configuration for non-existant schema tests #8366

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Mar 15, 2024

The current pyproject.toml enables asdf schema tests for 2 directories that do not exist:

jwst/pyproject.toml

Lines 226 to 228 in 77c4966

asdf_schema_tests_enabled = true
asdf_schema_validate_default = false
asdf_schema_root = "jwst/transforms/resources/schemas jwst/datamodels/schemas"

As the directories do not exist, no tests are run.

These could have been disabled in: #7439 which moved the schemas to stdatamodels (where they are tested)

This PR removes the configuration in pyproject.toml that enables the asdf schema tests.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@braingram braingram marked this pull request as ready for review March 15, 2024 13:54
@braingram braingram requested a review from a team as a code owner March 15, 2024 13:54
@braingram
Copy link
Collaborator Author

As seen in the py310 CI job. With this PR 3343 tests are being run:
https://github.com/spacetelescope/jwst/actions/runs/8297231789/job/22707918174?pr=8366
on main the same number of tests were run for this job:
https://github.com/spacetelescope/jwst/actions/runs/8296966128/job/22707041209#step:10:118

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.30%. Comparing base (2fb073e) to head (4928291).
Report is 33 commits behind head on master.

❗ Current head 4928291 differs from pull request most recent head edf231b. Consider uploading reports for the commit edf231b to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #8366       +/-   ##
===========================================
- Coverage   75.31%   56.30%   -19.01%     
===========================================
  Files         474      390       -84     
  Lines       38965    38889       -76     
===========================================
- Hits        29345    21895     -7450     
- Misses       9620    16994     +7374     
Flag Coverage Δ
nightly ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emolter
Copy link
Collaborator

emolter commented Mar 20, 2024

looks good to me

@braingram braingram requested a review from hbushouse April 11, 2024 18:20
@hbushouse hbushouse added this to the Build 11.0 milestone Apr 15, 2024
@hbushouse hbushouse merged commit 9429dc6 into spacetelescope:master Apr 15, 2024
23 of 24 checks passed
@braingram braingram deleted the asdf_schema_tests branch April 15, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants