Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable dependabot #8004

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Oct 11, 2023

This PR adds a dependabot configuration file which should also enable dependabot to run on this repo.

The configuration file contains sections to keep both github actions versions up-to-date and upper pins for python dependencies (via pip) up-to-date.

I don't have access to the repository settings and I'm not sure if dependabot is enabled there as I found one old PR for jwst from dependabot:
#6092

However it appears that at least the github actions are not being checked as an older version (3) of the checkout action is in use:

- uses: actions/checkout@v3

For an example of what to expect from dependabot PRs, here is the PR for asdf opened by dependabot to update the checkout action in that repository:
asdf-format/asdf#1639

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@github-actions github-actions bot added the automation Continuous Integration (CI) and testing automation tools label Oct 11, 2023
@braingram braingram marked this pull request as ready for review October 11, 2023 21:57
@braingram braingram requested a review from a team as a code owner October 11, 2023 21:57
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

Copy link
Collaborator

@zacharyburnett zacharyburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great, thanks! I'm assuming the dependabot PRs ping the codeowners by default, but to keep @hbushouse from being spammed by PRs all the time, is there a way to make it ping me in addition / instead?

@braingram
Copy link
Collaborator Author

Thanks for taking a look and good idea!

I think this should do it: ce3748f

I added you as one of the reviewers. There is another option for assignees but reviewers seemed like a better fit. I've never used either option so we may just have to wait and see what the first PR looks like and adjust as needed.

@zacharyburnett zacharyburnett merged commit e759d10 into spacetelescope:master Oct 13, 2023
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Continuous Integration (CI) and testing automation tools no-changelog-entry-needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants