-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update NIRCam PSF photometry notebook #156
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
larrybradley
had a problem deploying
to
ci_env
September 15, 2023 18:52 — with
GitHub Actions
Failure
larrybradley
force-pushed
the
psfphot
branch
from
September 15, 2023 18:58
7314d42
to
4f1b8b1
Compare
larrybradley
had a problem deploying
to
ci_env
September 15, 2023 18:58 — with
GitHub Actions
Failure
larrybradley
had a problem deploying
to
ci_env
September 16, 2023 14:16 — with
GitHub Actions
Failure
32 tasks
larrybradley
had a problem deploying
to
ci_env
February 22, 2024 19:34 — with
GitHub Actions
Failure
larrybradley
had a problem deploying
to
ci_env
February 22, 2024 19:34 — with
GitHub Actions
Failure
larrybradley
had a problem deploying
to
ci_env
February 22, 2024 19:34 — with
GitHub Actions
Failure
larrybradley
had a problem deploying
to
ci_env
February 22, 2024 19:34 — with
GitHub Actions
Failure
larrybradley
had a problem deploying
to
ci_env
February 22, 2024 19:34 — with
GitHub Actions
Failure
larrybradley
force-pushed
the
psfphot
branch
from
February 22, 2024 19:35
06c4f9e
to
1a01168
Compare
larrybradley
had a problem deploying
to
ci_env
February 22, 2024 19:35 — with
GitHub Actions
Failure
larrybradley
had a problem deploying
to
ci_env
February 22, 2024 19:35 — with
GitHub Actions
Failure
larrybradley
force-pushed
the
psfphot
branch
from
February 22, 2024 19:54
1a01168
to
15b6351
Compare
larrybradley
had a problem deploying
to
ci_env
February 22, 2024 19:54 — with
GitHub Actions
Failure
larrybradley
had a problem deploying
to
ci_env
February 22, 2024 19:54 — with
GitHub Actions
Failure
larrybradley
force-pushed
the
psfphot
branch
from
February 22, 2024 20:04
15b6351
to
f417b90
Compare
larrybradley
had a problem deploying
to
ci_env
February 22, 2024 20:05 — with
GitHub Actions
Failure
I updated this notebook to use f-strings so the PEP8 check would pass. |
This can be merged! |
haticekaratay
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the NIRCam PSF photometry notebook for the latest versions of the dependencies with Python 3.11.
This notebook checklist has been made available to us by the the Notebooks For All team.
Its purpose is to serve as a guide for both the notebook author and the technical reviewer highlighting critical aspects to consider when striving to develop an accessible and effective notebook.
The First Cell
<h1>
or# in markdown
).1., 2.,
etc. in Markdown).The Rest of the Cells
#
in Markdown) used in the notebook.Text
Code
Images
All images (jpg, png, svgs) have an image description. This could be
alt
property)alt
attribute with no value)Any text present in images exists in a text form outside of the image (this can be alt text, captions, or surrounding text.)
Visualizations
All visualizations have an image description. Review the previous section, Images, for more information on how to add it.
Visualization descriptions include
All visualizations and their parts have enough color contrast (color contrast checker) to be legible. Remember that transparent colors have lower contrast than their opaque versions.
All visualizations convey information with more visual cues than color coding. Use text labels, patterns, or icons alongside color to achieve this.
All visualizations have an additional way for notebook readers to access the information. Linking to the original data, including a table of the data in the same notebook, or sonifying the plot are all options.