Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6 code improvements #50

Merged
merged 2 commits into from
Jul 10, 2024
Merged

6 code improvements #50

merged 2 commits into from
Jul 10, 2024

Conversation

annajungbluth
Copy link
Contributor

Added option to save patches as .tif, and removed deletion of coordinate reference system in msg geoprocessor.

Open points in patcher:

  • add band_names to .nc patches?
  • do we also save the band_wavelengths in the .tif patches? I don't think we currently do.

Copy link
Member

@jejjohnson jejjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Merge when ready.

@jejjohnson
Copy link
Member

Added option to save patches as .tif, and removed deletion of coordinate reference system in msg geoprocessor.

Open points in patcher:

  • add band_names to .nc patches?

The band names should automatically be in the .nc patches. But their will be differences with the .tif patches. There one needs to manually set the band names (in order of the file) as attributes.

  • do we also save the band_wavelengths in the .tif patches? I don't think we currently do.

We also don’t do this for the tiff patches. One option could be to do the same as the band names. However, something easier to do is just to make a dictionary with the band names as keys and the wavelengths as values because:

  1. it’s a static variable that doesn’t change
  2. you’re only going to use that for ML training.
    This is actually what’s typically done in practice and I think the CloudSAT team already did this for their dataset.

@annajungbluth annajungbluth merged commit c9ca32e into main Jul 10, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants