Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid spam requests when fetching network status or account data #89

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

brusherru
Copy link
Member

This fixes adds:

  1. Retry interval to fetch Node Status is 1 minute, but the interval of fetching Node Status is still 5 minutes.
  2. Account data won't be fetched until Node Status is not retrieved. It prevents spamming to the unresponsive API endpoint.
  3. Even if Node Status is retrieved and layerDurationSec is 0 there will be a minimum fetch interval, which is equal to 10 seconds right now. We may set up the higher number, but it may make sense to allow using less value for a Standalone node (but it is not a case of the standard User).

This comment was marked as outdated.

Copy link

You can preview the changes at : https://444292b0.smapp-lite-prod.pages.dev

@brusherru brusherru self-assigned this Sep 17, 2024
@brusherru brusherru merged commit e7d2fab into main Sep 18, 2024
1 check passed
@brusherru brusherru deleted the fix-avoid-retry-spam branch September 18, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants