Implement edit/remove networks/accounts/keys. #77
Conversation
brusherru
force-pushed
the
feat-edit-data
branch
from
c871e7f to
73c3b21
Compare
brusherru
force-pushed
the
feat-edit-data
branch
from
73c3b21 to
9848c41
Compare
|
You can preview the changes at : https://ca5d83e0.smapp-lite-prod.pages.dev |
There was a problem hiding this comment.
For the UX part:
Once the user deletes all accounts, there's this screen suggesting to switch the account.
Sometime in the future, it would be good to improve it - show msg that there are no accounts currently available, instruct to go create/import one, maybe even include a link opening the create or/and import account.
|
You can preview the changes at : https://765f10ab.smapp-lite-prod.pages.dev |
|
@monikasmolarek thanks a lot!
Also I can confirm that there is a bug as you recorded on the video above. |
There was a problem hiding this comment.
just noticed one more tiny detail - the modal to delete the account has a button that says "Delete Key".
Nothing serious but it actually confused me a bit while doing things quickly and I had to cancel and start again to make sure I was not mistaken and deleted account, not key.
|
Also, the current possibilities open a new use case. For example: What if someone deletes both - all accounts, all keys -> The wallet is empty, we can of course create a new account - derive it from a foreign key, but the modal still has the "local key" drop-down, which is now empty. Should we allow to put there a hex and inform that it imports this key automatically while creating the account? Or should we hide the local key option? The transactions' modals/management handle view-only perfectly well, not mentioning the local key to sign when the key isn't there. 👌 So I thought managing accounts could also be more robust. |
It allows to put there a public key, but you need to switch to the foreign key, yeah. |
|
You can preview the changes at : https://7eb429d1.smapp-lite-prod.pages.dev |
Do we need "templateAddress" field here?
Also for me it is strange that I can replace the key for an existing account. |
|
You can preview the changes at : https://fbeb1312.smapp-lite-prod.pages.dev |
|
@dioexul I've added a yellow text under the name input saying that changing anything below will affect the account's address and change it only on your own risk. I think now it will be more clear that in a common case you should not change anything. But if you really have a mistake there — it will be possible to change anything. Sounds good? |
|
@brusherru yes, having a warning is better. |
|
You can preview the changes at : https://19b5255a.smapp-lite-prod.pages.dev |
It closes #42, closes #43, closes #44.
I had to refactor some input components (related to key and account selection).
So please, check it out carefully, just in case I broke something and didn't find :)
Actually more refactoring is needed, but I decided to finish it later.
Also, I moved adding of the new network inside the special "Edit networks" drawer (mb better to rename it into "Manage networks"?). Hopefully it's fine from the UX perspective.