Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiVCS: Added is_default into stack/module data source and prevent panic on detached VCS integration #512

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

truszkowski
Copy link
Contributor

@truszkowski truszkowski commented Feb 7, 2024

Description of the change

  • We've added is_default into stack/module resource. We need to do the same with data sources as well.
  • Prevent panic on detached VCS integration

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (non-breaking change that adds documentation)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • Examples for new resources and data sources have been added
  • Default values have been documented in the description (e.g., "Dummy: (Boolean) Blah blah. Defaults to false.)
  • If the action fails that checks the documentation: Run go generate to make sure the docs are up to date

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Pull Request is no longer marked as "draft"
  • Reviewers have been assigned
  • Changes have been reviewed by at least one other engineer

TheMacies
TheMacies previously approved these changes Feb 7, 2024
adamconnelly
adamconnelly previously approved these changes Feb 7, 2024
peterdeme
peterdeme previously approved these changes Feb 7, 2024
peterdeme
peterdeme previously approved these changes Feb 7, 2024
@truszkowski truszkowski changed the title MultiVCS: fix: add stack/module -> vcs integration -> is_default MultiVCS: fix infinity diff and prevent panic on detached VCS integration Feb 7, 2024
@truszkowski truszkowski changed the title MultiVCS: fix infinity diff and prevent panic on detached VCS integration MultiVCS: Added is_default into stack/module data source and prevent panic on detached VCS integration Feb 7, 2024
@truszkowski truszkowski force-pushed the add-vcs-integration-is-default-into-data-source branch from 3efef2d to 9db2ce0 Compare February 7, 2024 15:22
@truszkowski truszkowski merged commit eb023b9 into main Feb 7, 2024
7 checks passed
@truszkowski truszkowski deleted the add-vcs-integration-is-default-into-data-source branch February 7, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants