Modify markup tag interfaces and fix some bugs #5442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR marks the
IMarkupTaginterface and associated methods as obsolete, and adds a newIMarkupTagHandlerinterface and methods inMarkupTagManagerthat should replace the old ones.The main reason for this change is to try prevent confusion & bugs, due to users assuming that there are multiple tag instances per rich text tag, when in reality the tag manager only ever creates one instance per tag type. This confusion has already lead to a bug in content, where
TextLinkTagassumes that it has an instance per control.This PR also fixes another bug, where controls that were using the
RichTextEntryconstructor to add child controls never removed those controls once the entry was removed.