Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement locale for StoreProduct #82

Merged
merged 9 commits into from
Oct 14, 2024
Merged

Conversation

zy19890102
Copy link
Contributor

Implement locale for StoreProduct

@@ -42,6 +42,10 @@ extension SK1StoreProduct: ISKProduct {
var currencySymbol: String? {
numberFormatter.currencySymbol
}

var locale: Locale {
self.product.priceLocale
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self is not needed here. Could you please remove the self keyword in places where it isn't explicitly needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@ns-vasilev ns-vasilev merged commit ff78732 into space-code:dev Oct 14, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants