Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor plugins for using Version Catalogs #30 #33

Merged
merged 2 commits into from
May 28, 2024
Merged

Refactor plugins for using Version Catalogs #30 #33

merged 2 commits into from
May 28, 2024

Conversation

davthecodercom
Copy link
Contributor

@davthecodercom davthecodercom commented May 27, 2024 •
edited
Loading

🎩 How was this resolved?

  • Add plugins in to toml [plugins] space
  • Replace the current id for alias
  • Extra: I moved the minimum, target and compile sdk to toml and remove it from gradle.properties file.

@davthecodercom davthecodercom changed the title Move all possible plugins in to toml and replace where is called. Refactor plugins for using Version Catalogs #30 May 27, 2024
@davthecodercom davthecodercom mentioned this pull request May 27, 2024
Open
soygabimoreno
soygabimoreno approved these changes May 28, 2024
View reviewed changes
Copy link
Owner

@soygabimoreno soygabimoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 🎉

@soygabimoreno soygabimoreno merged commit 92efbc8 into soygabimoreno:main May 28, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soygabimoreno soygabimoreno soygabimoreno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davthecodercom @soygabimoreno