Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: [#6701] Add ConnectorClientOptions to ConfigurationBotFrameworkAuthentication #542

Closed
wants to merge 1 commit into from

Conversation

sw-joelmut
Copy link

@sw-joelmut sw-joelmut commented Nov 3, 2023

Addresses # 6701
#minor

Description

This PR ports from JavaScript the ability to add a custom user agent through the new ConnectorClientOptions, provided in the ConfigurationBotFrameworkAuthentication class.

Specific Changes

  • Added ConnectorClientOptions class containing the user agent property.
  • Added AddUserAgent method to the ConnectorClientEx static class.
  • Connected the new ConnectorClientOptions class from ConfigurationBotFrameworkAuthentication through the code flow, up to ConnectorFactoryImpl and UserTokenClientImpl.
  • Added new unit tests around the new ConnectorClientOptions class.

Testing

The following images show the new test passing and how the new ConnectorClientOptions could be used from a bot.
imagen
imagen

@sw-joelmut
Copy link
Author

imagen

@sw-joelmut
Copy link
Author

Close as it's no longer required

@sw-joelmut sw-joelmut closed this Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants