Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix output encoding error #27

Merged
merged 2 commits into from
May 29, 2018
Merged

Fix output encoding error #27

merged 2 commits into from
May 29, 2018

Conversation

linusruth
Copy link
Contributor

@linusruth linusruth commented May 25, 2018 •
edited
Loading

  • Fix output encoding error in PowerShell script. @chaim1221 reported it as an issue since it's polluting the otherwise clean looking build log. The solution is to start a cmd console so that [Console]::OutputEncoding has something to modify. Whether or not you encounter the error depends on how you invoke PowerShell. Some contexts include a cmd console already, while others do not.

@linusruth linusruth self-assigned this May 25, 2018
@linusruth linusruth requested a review from chaim1221 May 25, 2018 23:05
@linusruth linusruth mentioned this pull request May 25, 2018
Closed
@linusruth
Copy link
Contributor Author

Going to go ahead and merge this in.

@linusruth linusruth merged commit 49f05be into master May 29, 2018
@linusruth linusruth deleted the fix-output-encoding-error branch May 29, 2018 16:25
@chaim1221
Copy link
Contributor

Thanks! I'm just getting back into the game here. Thanks for closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaim1221 chaim1221 Awaiting requested review from chaim1221

Assignees

@linusruth linusruth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linusruth @chaim1221