Make users provider agnostic #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use string representation defined from within package * Do not allow GitHub as login provider for now
|
@YaleChen299 I chose for it to be done this way so that we can keep a separate notion of which login providers are supported from which login providers are enabled for a particular deployment (can easily be checked using a config flag in the validation method). What do you think? |
|
Waiting to fix error: User creation in DB somehow calls the |
Prevents GORM for automatically generating the string representation.
ngruiyanrena
approved these changes
Jul 22, 2023
Merged
Okay! I think this looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #18.
We include a schema migration, but not a data migration, as it is not necessary at this stage of the codebase (not deployed).