Rewrite search #926
Merged
Rewrite search #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite index search and text search(and fix #913 and #905)
Have tested the index search in its coverage, and validity of the urls.Works well.
Know issues and next step:
1 Do not works for some symbols, big theta for example (though I do not think user can easily input and search for them as well)
2 Do not treat what is designed to be latex, roman, italic properly, now treat them as normal text.
3 No "see also in index, might be a good next step to add them.
4 Find clever and more robust way to test for the correctness of the url generated. (Other than manual tracing)
5 No automate test done on text search yet.
Also manually check for issue mentioned in #913 and #905 after rewriting. Unsurprisingly, they are all fixed.
I still kept the old "generateSearchData" as the frontend have not been updates yet, and the current frontend depends on it.