-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display Stories Users in Admin Panel #2763
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tab is still showing users, instead of stories users.
meant to be analagous to AdminPanelCourseRegistrations, based on the return fields of /groups/{groupId}/users from stories backend.
Role to StoriesRole, courseRegId to id (to match StoriesUsers)
…nto feature/stories-users
suppressCellSelection of <AgGridReact> is now suppressCellFocus (AG-5953). cellRendererFramework of ColDef is now cellRenderer, see [blog](https://blog.ag-grid.com/whats-new-in-ag-grid-27/).
added sagas, actions, calls to the backend to enable functionality of deleting user and updating their roles in the Stories Users panel. updated some variable names (previously copied from Users panel) to match newly created names.
refactored code based on changes made by linter during pre-push hook. also refactored text shown in dialog box upon clicking Delete User button in Stories User panel.
…demy/frontend into feature/stories-users
…nto feature/stories-users
…nto feature/stories-users
…nto feature/stories-users
To align with new updates in the default `RolesCell` component.
Reflect new updates to the `UserActionsCell` component.
Reflect recent updaates to `UserConfigPanel`.
RichDom2185
approved these changes
May 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, sorry for the late review, LGTM, thanks!
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #2578
Adds the (working) Stories User and User panels in the admin panel.