Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Stories Users in Admin Panel #2763

Merged
merged 73 commits into from
May 12, 2024
Merged

Conversation

zsiggg
Copy link
Contributor

@zsiggg zsiggg commented Feb 5, 2024

Supersedes #2578

Adds the (working) Stories User and User panels in the admin panel.

@zsiggg zsiggg self-assigned this Feb 5, 2024
suppressCellSelection of <AgGridReact> is now suppressCellFocus
(AG-5953).
cellRendererFramework of ColDef is now cellRenderer, see
[blog](https://blog.ag-grid.com/whats-new-in-ag-grid-27/).
@coveralls
Copy link

coveralls commented Feb 12, 2024

Pull Request Test Coverage Report for Build 9050497480

Details

  • 13 of 87 (14.94%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 31.962%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/features/stories/StoriesActions.ts 2 3 66.67%
src/features/stories/StoriesReducer.ts 0 1 0.0%
src/commons/application/actions/SessionActions.ts 2 4 50.0%
src/pages/academy/adminPanel/AdminPanel.tsx 0 5 0.0%
src/pages/academy/adminPanel/subcomponents/storiesUserConfigPanel/RolesCell.tsx 0 6 0.0%
src/pages/academy/adminPanel/subcomponents/storiesUserConfigPanel/StoriesUserActionsCell.tsx 0 13 0.0%
src/pages/academy/adminPanel/subcomponents/storiesUserConfigPanel/StoriesUserConfigPanel.tsx 0 13 0.0%
src/commons/sagas/StoriesSaga.ts 2 18 11.11%
src/features/stories/storiesComponents/BackendAccess.ts 3 20 15.0%
Totals Coverage Status
Change from base Build 9049787385: -0.1%
Covered Lines: 5033
Relevant Lines: 14786

💛 - Coveralls

@RichDom2185 RichDom2185 self-requested a review February 12, 2024 12:57
RichDom2185 and others added 12 commits February 18, 2024 11:54
added sagas, actions, calls to the backend to enable functionality of
deleting user and updating their roles in the Stories Users panel.
updated some variable names (previously copied from Users panel) to
match newly created names.
refactored code based on changes made by linter during pre-push hook.
also refactored text shown in dialog box upon clicking Delete User
button in Stories User panel.
To align with new updates in the default `RolesCell` component.
Reflect new updates to the `UserActionsCell` component.
Reflect recent updaates to `UserConfigPanel`.
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sorry for the late review, LGTM, thanks!

@RichDom2185 RichDom2185 enabled auto-merge (squash) May 12, 2024 09:49
@RichDom2185 RichDom2185 merged commit 4b63863 into master May 12, 2024
8 checks passed
@RichDom2185 RichDom2185 deleted the feature/stories-users branch May 12, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants