-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved to date_source_exist from table_exists #145
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice!
Which versions of ActiveRecord support that? |
date_source_exists? is available since the rails version 4.2.7 https://apidock.com/rails/v4.2.7/ActiveRecord/ConnectionAdapters/SchemaStatements/data_source_exists%3F |
@grobie Is there any way i can contribute to get this merged? |
@nikonoll so the issue is that there are known users who are stuck on Rais 2.3. I haven't worked with LHM in a while though. It could be an option to force them to use an older version of LHM. |
@grobie Okay, thanks for letting me know. Is there any official status of this gem concerning it being maintained actively and kept up to date? For us it would be great to know weather we should stick to LHM in general. |
@nikonoll At SoundCloud we mostly use Percona's online-schema-change tool now. |
There were some active contributors to LHM and I'd be happy to add someone as collaborator if they want to step up and take over maintainership. |
@grobie Thanks for the info |
As of this change in Rails (rails/rails#21601) the #table_exists? should be replaced by #data_source_exists?
There was already an open issue for this matter: #144