Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved to date_source_exist from table_exists #145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Moved to date_source_exist from table_exists #145

wants to merge 1 commit into from

Conversation

nikoatwork
Copy link

As of this change in Rails (rails/rails#21601) the #table_exists? should be replaced by #data_source_exists?

There was already an open issue for this matter: #144

@nikoatwork nikoatwork changed the title Moved to date_sources_exist from table_exists Moved to date_source_exist from table_exists Jun 27, 2017
Copy link

@moonzez moonzez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@grobie
Copy link
Contributor

grobie commented Jun 27, 2017

Which versions of ActiveRecord support that?

@moonzez
Copy link

moonzez commented Jun 28, 2017

date_source_exists? is available since the rails version 4.2.7 https://apidock.com/rails/v4.2.7/ActiveRecord/ConnectionAdapters/SchemaStatements/data_source_exists%3F

@nikoatwork
Copy link
Author

@grobie Is there any way i can contribute to get this merged?

@grobie
Copy link
Contributor

grobie commented Jul 4, 2017

@nikonoll so the issue is that there are known users who are stuck on Rais 2.3. I haven't worked with LHM in a while though. It could be an option to force them to use an older version of LHM.

@nikoatwork
Copy link
Author

@grobie Okay, thanks for letting me know. Is there any official status of this gem concerning it being maintained actively and kept up to date? For us it would be great to know weather we should stick to LHM in general.

@grobie
Copy link
Contributor

grobie commented Jul 11, 2017

@nikonoll At SoundCloud we mostly use Percona's online-schema-change tool now.

@grobie
Copy link
Contributor

grobie commented Jul 11, 2017

There were some active contributors to LHM and I'd be happy to add someone as collaborator if they want to step up and take over maintainership.

@nikoatwork
Copy link
Author

@grobie Thanks for the info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants