allow to configure definition path

fix scenic-views#261

lib/generators/scenic/view/view_generator.rb

@@ -1,6 +1,8 @@
 require "rails/generators"
 require "rails/generators/active_record"
 require "generators/scenic/materializable"
+require "scenic/definition"
+require "scenic/definitions"
 
 module Scenic
   module Generators
@@ -11,16 +13,16 @@ class ViewGenerator < Rails::Generators::NamedBase
       source_root File.expand_path("templates", __dir__)
 
       def create_views_directory
-        unless views_directory_path.exist?
-          empty_directory(views_directory_path)
+        unless Scenic.configuration.definitions_path.exist?
+          empty_directory(Scenic.configuration.definitions_path)
         end
       end
 
       def create_view_definition
         if creating_new_view?
           create_file definition.path
         else
-          copy_file previous_definition.full_path, definition.full_path
+          copy_file previous_definition.path, definition.path
         end
       end
 
@@ -44,10 +46,7 @@ def self.next_migration_number(dir)
 
       no_tasks do
         def previous_version
-          @previous_version ||=
-            Dir.entries(views_directory_path)
-              .map { |name| version_regex.match(name).try(:[], "version").to_i }
-              .max
+          @previous_version ||= previous_definition.version
         end
 
         def version
@@ -73,30 +72,20 @@ def activerecord_migration_class
 
       private
 
-      alias singular_name file_name
-
-      def file_name
-        super.tr(".", "_")
-      end
-
-      def views_directory_path
-        @views_directory_path ||= Rails.root.join("db", "views")
-      end
-
-      def version_regex
-        /\A#{plural_file_name}_v(?<version>\d+)\.sql\z/
+      def definitions
+        @definitions ||= Scenic::Definitions.new(plural_file_name)
       end
 
       def creating_new_view?
-        previous_version.zero?
+        definitions.none?
       end
 
       def definition
         Scenic::Definition.new(plural_file_name, version)
       end
 
       def previous_definition
-        Scenic::Definition.new(plural_file_name, previous_version)
+        definitions.max || Scenic::Definition.new(plural_file_name, 0)
       end
 
       def destroying?

lib/scenic.rb

@@ -1,7 +1,6 @@
 require "scenic/configuration"
 require "scenic/adapters/postgres"
 require "scenic/command_recorder"
-require "scenic/definition"
 require "scenic/railtie"
 require "scenic/schema_dumper"
 require "scenic/statements"

lib/scenic/configuration.rb

@@ -1,3 +1,5 @@
+require_relative "adapters/postgres"
+
 module Scenic
   class Configuration
     # The Scenic database adapter instance to use when executing SQL.
@@ -6,8 +8,15 @@ class Configuration
     # @return Scenic adapter
     attr_accessor :database
 
+    # The full path where is stored views definition sql files.
+    #
+    # Defaults to `Rails.root.join("db", "views")` an instance of {Pathname}
+    # @return the path
+    attr_accessor :definitions_path
+
     def initialize
-      @database = Scenic::Adapters::Postgres.new
+      self.database = Scenic::Adapters::Postgres.new
+      self.definitions_path = Rails.root.join("db", "views")
     end
   end
 

lib/scenic/definition.rb

@@ -7,19 +7,15 @@ def initialize(name, version)
     end
 
     def to_sql
-      File.read(full_path).tap do |content|
+      File.read(path).tap do |content|
         if content.empty?
           raise "Define view query in #{path} before migrating."
         end
       end
     end
 
-    def full_path
-      Rails.root.join(path)
-    end
-
     def path
-      File.join("db", "views", filename)
+      Scenic.configuration.definitions_path.join(filename)
     end
 
     def version

lib/scenic/definitions.rb

@@ -0,0 +1,38 @@
+require_relative "definition"
+
+module Scenic
+  # @api private
+  class Definitions
+    include Enumerable
+    include Comparable
+
+    attr_reader :name, :views_directory_path
+
+    def initialize(name)
+      @name = name
+    end
+
+    def each
+      versions.each do |version|
+        yield Scenic::Definition.new(name, version)
+      end
+    end
+
+    def <=>(definition_a, definition_b)
+      definition_a.version <=> definition_b.version
+    end
+
+    def versions
+      @versions ||= Dir.entries(Scenic.configuration.definitions_path)
+        .map { |name| version_regex.match(name).try(:[], "version").try(:to_i) }
+        .compact
+        .sort
+    end
+
+    private
+
+    def version_regex
+      /\A#{name}_v(?<version>\d+)\.sql\z/
+    end
+  end
+end

lib/scenic/statements.rb

@@ -1,3 +1,4 @@
+require_relative "definition"
 module Scenic
   # Methods that are made available in migrations for managing Scenic views.
   module Statements

spec/scenic/definition_spec.rb

@@ -23,7 +23,7 @@ module Scenic
 
     describe "path" do
       it "returns a sql file in db/views with padded version and view name" do
-        expected = "db/views/searches_v01.sql"
+        expected = Rails.root.join("db/views/searches_v01.sql")
 
         definition = Definition.new("searches", 1)
 
@@ -32,16 +32,9 @@ module Scenic
 
       it "handles schema qualified view names" do
         definition = Definition.new("non_public.searches", 1)
+        expected = Rails.root.join("db/views/non_public_searches_v01.sql")
 
-        expect(definition.path).to eq "db/views/non_public_searches_v01.sql"
-      end
-    end
-
-    describe "full_path" do
-      it "joins the path with Rails.root" do
-        definition = Definition.new("searches", 15)
-
-        expect(definition.full_path).to eq Rails.root.join(definition.path)
+        expect(definition.path).to eq expected
       end
     end
 

spec/support/generator_spec_setup.rb

@@ -8,7 +8,17 @@
     fake_rails_root = File.expand_path("../../tmp", __dir__)
     allow(Rails).to receive(:root).and_return(Pathname.new(fake_rails_root))
 
+    Scenic.configure do |configuration|
+      configuration.definitions_path = Pathname.new(fake_rails_root).join("db", "views")
+    end
+
     destination fake_rails_root
     prepare_destination
   end
+
+  config.before(:each) do
+    Scenic.configure do |configuration|
+      configuration.definitions_path = Rails.root.join("db", "views")
+    end
+  end
 end

spec/support/view_definition_helpers.rb

@@ -1,10 +1,10 @@
 module ViewDefinitionHelpers
   def with_view_definition(name, version, schema)
     definition = Scenic::Definition.new(name, version)
-    FileUtils.mkdir_p(File.dirname(definition.full_path))
-    File.open(definition.full_path, "w") { |f| f.write(schema) }
+    FileUtils.mkdir_p(File.dirname(definition.path))
+    File.open(definition.path, "w") { |f| f.write(schema) }
     yield
   ensure
-    FileUtils.rm_f(definition.full_path)
+    FileUtils.rm_f(definition.path)
   end
 end