DELETE, POST, PUT post/v2 API 마이그레이션 #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
borimong
reviewed
Nov 2, 2024
| @@ -77,7 +77,7 @@ export const useMutationPostLike = (queryId: string) => { | |||
|
|
|||
| return useMutation({ | |||
| mutationKey: ['getPost', queryId], | |||
| mutationFn: () => postLike(queryId), | |||
| mutationFn: () => postLike(+queryId), | |||
There was a problem hiding this comment.
여기서 queryId 앞에 있는 +는 무엇일까요?!
There was a problem hiding this comment.
혹시 string 형식으로 들어와도 숫자 형식으로 인자 전달해주게끔 명시적으로 작성해둔 것입니다!
borimong
reviewed
Nov 2, 2024
| @@ -30,7 +30,7 @@ export const useMutationUpdateLike = (take: number, meetingId?: number) => { | |||
| const queryClient = useQueryClient(); | |||
|
|
|||
| return useMutation({ | |||
| mutationFn: (postId: number) => postLike(String(postId)), | |||
| mutationFn: (postId: number) => postLike(postId), | |||
There was a problem hiding this comment.
이 코드를 보니까, postId 를 number 타입으로 받아오고 있고, postLike 에서 기존에 있던 String() 을 제거해주셨는데요! postLike 의 인자 타입이 string 에서 number 로 수정된 것 같은데, 혹시 의도된 것일까요?
There was a problem hiding this comment.
이전 v2로 마이그레이션된 것과 형태를 맞추기 위해 의도하였습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚩 관련 이슈
📋 작업 내용
📌 PR Point
📸 스크린샷
DELETE
POST like
PUT