Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat/#848] 광고 구좌 캐러셀 dot botton 색상 변경 #849

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

ocahs9
Copy link
Contributor

@ocahs9 ocahs9 commented Sep 11, 2024

🚩 관련 이슈

📋 작업 내용

  • grey10 -> grey50 으로 dot 버튼 색상 변경

📌 PR Point

📸 스크린샷

변경된 내용
image

@ocahs9 ocahs9 added the size/S label Sep 11, 2024
@ocahs9 ocahs9 self-assigned this Sep 11, 2024
Copy link

height bot commented Sep 11, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 파일은 왜 수정 사항이 생겼을까요~? 이번 기능과 관련 없는 수정이라면, 제외 후 pr 올려주세요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기능과는 관련 없는데, "source.organizeImports": true 옵션을 통해서 정리한 모습입니다!
import 문을 보기 좋게 정렬하면 좋을 것 같아서 반영해둔건데, 생각해보니 다른사람과 동시에 같은 파일을 작업해야한다면 충돌 문제가 날 수 있겠네요.. 이번만 반영해두고 다음부터는 해당 옵션 꺼두도록 하겠습니다!

@pull-request-size pull-request-size bot added size/M and removed size/S labels Sep 16, 2024
@ocahs9 ocahs9 merged commit c6770c4 into develop Sep 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

캐러셀 배너 색상 변경
2 participants