Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

광고 구좌 QA #826

Merged
merged 4 commits into from
Aug 30, 2024
Merged

광고 구좌 QA #826

merged 4 commits into from
Aug 30, 2024

Conversation

borimong
Copy link
Contributor

@borimong borimong commented Aug 30, 2024

🚩 관련 이슈

📋 작업 내용

  • useMemo 를 활용한 랜덤 셔플 캐러셀 구현
  • restoreScrollPosition 함수 수정

📌 PR Point

  • 무슨 이유로 어떻게 코드를 변경했는지
  • 어떤 위험이나 우려가 발견되었는지
  • 어떤 부분에 리뷰어가 집중해야 하는지
  • 개발하면서 어떤 점이 궁금했는지

📸 스크린샷

@borimong borimong self-assigned this Aug 30, 2024
@borimong borimong requested a review from R1mmm as a code owner August 30, 2024 03:24
Copy link

height bot commented Aug 30, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@borimong borimong merged commit a32c770 into develop Aug 30, 2024
2 checks passed
@borimong borimong deleted the feat/#825 branch August 30, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

광고 구좌 QA
1 participant