chore(all): Optimize packages #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 전체 패키지를 배포하고 있던 기존의 번들을 dist 폴더와 variable.css만 배포하여 번들사이즈를 줄입니다.
Brokyeom
requested review from
sohee-K,
jungwoo3490 and
suwonthugger
as code owners
|
🦋 Changeset detectedLatest commit: d4630ee The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Brokyeom
commented
Nov 15, 2024
Comment on lines
-25
to
-26
| "@vanilla-extract/sprinkles": "1.6.1", | ||
| "tsup": "^8.0.2" |
There was a problem hiding this comment.
deDepedancy에 이미 tsup이 존재하기 때문에 dependacy에서 제거했습니다.
jungwoo3490
approved these changes
Nov 15, 2024
packages/ui/package.json
Outdated
| @@ -22,8 +28,7 @@ | |||
| "@sopt-makers/fonts": "workspace:^", | |||
| "@sopt-makers/icons": "workspace:^", | |||
| "@vanilla-extract/css": "^1.14.0", | |||
| "@vanilla-extract/sprinkles": "1.6.1", | |||
| "tsup": "^8.0.2" | |||
| "@vanilla-extract/sprinkles": "1.6.1" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경사항
링크
시급한 정도
🏃♂️ 보통 : 최대한 빠르게 리뷰 부탁드립니다.
기타 사항