Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Icon): mds, phone/birth 아이콘 추가합니다 #188

Merged
merged 6 commits into from
Oct 31, 2024
Merged

feat(Icon): mds, phone/birth 아이콘 추가합니다 #188

merged 6 commits into from
Oct 31, 2024

Conversation

suwonthugger
Copy link
Member

변경사항

close #187

링크

https://sopt-makers.slack.com/lists/T040QGZF77H/F07LCJ586TS?record_id=Rec07TS9CABM2

시급한 정도

🏃‍♂️ 보통 : 최대한 빠르게 리뷰 부탁드립니다.

기타 사항

@suwonthugger suwonthugger linked an issue Oct 27, 2024 that may be closed by this pull request
feat(Icon): mds, phone/birth 아이콘 추가합니다 #187
Closed
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d68ca69

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@suwonthugger suwonthugger self-assigned this Oct 27, 2024
@Brokyeom
Copy link
Member

image

브랜치명에 한글이 들어가면 유니코드로 인식돼서 경고가 뜨는 것 같군요 브랜치명은 영문으로 작성하는게 좋을 것 같아요!

@Brokyeom
Copy link
Member

bump는 patch 로 올려주시고 rerequest 주세요!

@suwonthugger
Copy link
Member Author

헉 브랜치 조심하겠습니다! 감사합니다

@Brokyeom Brokyeom merged commit 17b473b into main Oct 31, 2024
1 check passed
@Brokyeom Brokyeom deleted the feat/#187/phone-birth-아이콘추가 branch October 31, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brokyeom Brokyeom Awaiting requested review from Brokyeom Brokyeom is a code owner

@sohee-K sohee-K Awaiting requested review from sohee-K sohee-K is a code owner

@jungwoo3490 jungwoo3490 Awaiting requested review from jungwoo3490 jungwoo3490 is a code owner

Assignees

@suwonthugger suwonthugger

Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(Icon): mds, phone/birth 아이콘 추가합니다
2 participants
@suwonthugger @Brokyeom