Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Button): Button Medium 의 text size를 14px -> 16px로 변경합니다. #167

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

suwonthugger
Copy link
Member

@suwonthugger suwonthugger commented Oct 10, 2024

변경사항

close #166

MDS 요청에 따라서 일관성있게 Button의 size = 'md' 일때 text size를 14px -> 16px 로 변경했습니다.

  • 변경 전 후
image image

링크

https://sopt-makers.slack.com/lists/T040QGZF77H/F07LCJ586TS?record_id=Rec07S0BXH1S4

시급한 정도

🏃‍♂️ 보통 : 최대한 빠르게 리뷰 부탁드립니다.

기타 사항

간단한 반영사항이라서 편하게 확인해주시면 감사하겠습니다!

Copy link

height bot commented Oct 10, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

changeset-bot bot commented Oct 10, 2024

⚠️ No Changeset found

Latest commit: 6e95309

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Brokyeom
Copy link
Member

bump patch 로 올려주세요!

@suwonthugger
Copy link
Member Author

patch로 올렸습니다!

@Brokyeom Brokyeom merged commit 7d8e506 into main Oct 10, 2024
1 check passed
@Brokyeom Brokyeom deleted the refactor/#166/button-text-size-change branch October 10, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor(Button): Button Medium 의 text size를 14px -> 16px로 변경합니다.
2 participants