Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(colors): backgroundDimmed 컬러 피그마와 다르게 적용되어있는 부분을 수정합니다. #162

Merged
merged 2 commits into from
Oct 6, 2024

Conversation

suwonthugger
Copy link
Member

@suwonthugger suwonthugger commented Oct 6, 2024

변경사항

image

피그마에서 grayAlpha100이라 되어있는 부분도 grayAlpha800으로 수정되어야할것 같아서 피그마 코멘트로 남겨놨어요
https://www.figma.com/design/ZuAGH1zZDxduHsjCZm8kfH/%F0%9F%9A%80-makers-design-system?node-id=1110-186&m=dev

간단하게 피그마와 상이한 부분을 수정했습니다.

// 수정 전
backgroundDimmed: 'rgba(15, 15, 18, 0.1)', // grayAlpha100

// 수정 후
backgroundDimmed: 'rgba(15, 15, 18, 0.8)', // grayAlpha800

리뷰 받고 npm 패키지 배포 후,
스토리북 수정 / 크로마틱 배포하겠습니다!

링크

시급한 정도

🏃‍♂️ 보통 : 최대한 빠르게 리뷰 부탁드립니다.

기타 사항

Copy link

changeset-bot bot commented Oct 6, 2024

⚠️ No Changeset found

Latest commit: edcd738

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

height bot commented Oct 6, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

attention: '#FFC234',
error: '#F04251',
background: '#0F1012', // gray950
backgroundDimmed: 'rgba(15, 15, 18, 0.8)', // grayAlpha800
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backgroundDimmed 수정한 부분입니다!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다. bump patch 로 추가하고 바로 가시죠~!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵! 완료했습니다. 스토리북은 머지되고 npm 패키지 배포 된 후에 작성 가능할것 같아요!

@Brokyeom Brokyeom merged commit 5eae36b into main Oct 6, 2024
1 check passed
@Brokyeom Brokyeom deleted the fix/#161/dimmed-color-fix branch October 6, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(colors): backgroundDimmed 컬러 피그마와 다르게 적용되어있는 부분을 수정합니다.
2 participants