Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M3 intergration PR #85

Merged
merged 99 commits into from
Apr 26, 2024
Merged

M3 intergration PR #85

merged 99 commits into from
Apr 26, 2024

Conversation

petertheprocess
Copy link
Contributor

@petertheprocess petertheprocess commented Apr 25, 2024 •
edited
Loading

_._20240425141524.mp4

current issue:

  • timer display as NaN
  • AudioRecorder btns flicker when typing on answer box.
  • Share audio to all players is not working.
  • AudioRecorder will get rerenderd once we push the share btn. (when call stomp send api)

Haaaan1 and others added 30 commits April 14, 2024 07:41
@Haaaan1
Update Contribution.md
bd162db
@petertheprocess
Update Contribution.md
0eb7cf4
@petertheprocess
Update Contribution.md
29511b0
@petertheprocess
Update Contribution.md
a509214
@petertheprocess
Update Contribution.md
5d89b6c
@Haaaan1
Merge pull request #74 from sopra-fs24-group-09/feature/lobby-ui
ba16c67 
Feature/lobby UI
@Haaaan1
Revert "Feature/lobby UI"
811978c
@Haaaan1
Merge pull request #75 from sopra-fs24-group-09/revert-74-feature/lob…
21c920e 
…by-ui

Revert "Feature/lobby UI"
@petertheprocess
Update build_test_before_pr.yml
1072dd0
@petertheprocess
Update main.yml, add PR deploy for main branch
83b221c
@petertheprocess
fix createRoom func
c675bf9
@zihanltesla
Merge pull request #81 from sopra-fs24-group-09/dev
4c89a02 
Fixed url for room direction
@Zehao-Zhang
04-22 21:15
2a87a78
@yixuan-zhou-uzh
[fix] userId and roomId to be string
091e7c9
@yixuan-zhou-uzh
[feat] upload and leave room button added
e1037b9
@Zehao-Zhang
correct url to /app/message
87cc6e1
@yixuan-zhou-uzh
[feat] roomOwner showing the start button
45bbaf8
@yixuan-zhou-uzh
Merge remote-tracking branch 'origin/M3-intergration-test' into M3-in…
5eaede8 
…tergration-test
@Haaaan1
Fix edit profile and avatar bugs
f61a4e7
@zihanltesla
Updated roomId for distinguish Chanels
e2aadba
@petertheprocess
Fix waveplayer no audio animation
16cf458
@petertheprocess
Put VolumeBar ui in header, also update gameroom layout
6017a40
@petertheprocess
[feature] add Volume tunning function. fix #66 #49
c89accc 
need optimize later to avoid unnecessary rerender, and also debounce throttle are needed.
@zihanltesla
For enteroom and exitroom
1d556d4
@Haaaan1
Modify fetching room player lists data
b6973e1
@zihanltesla
Fixed unready
d095814
@zihanltesla
Merge branch 'M3-intergration-test' of github.com:sopra-fs24-group-09…
a4023d4 
…/sopra-fs24-group-09-client into M3-intergration-test
@yixuan-zhou-uzh
[fix] player info updated
c032861
@petertheprocess
Merge pull request #53 from sopra-fs24-group-09/Volume-widget-dev
61d6aca 
Volume tuning widget added
@petertheprocess
fix gameroom playercontainer ui
1d5a94f
petertheprocess and others added 9 commits April 26, 2024 16:13
@petertheprocess
Prevent unsupported broswer play game. fix #94
c909188
@zihanltesla
websocket forward error message
e7ab79f
@zihanltesla
Add nav to lobby
8fce7d5
@petertheprocess
Merge pull request #96 from sopra-fs24-group-09/feature/chrome-only-c…
367d12c 
…heck

Prevent unsupported broswer play game. fix #94
@petertheprocess
Merge pull request #97 from sopra-fs24-group-09/M3-integration-test-a…
757c8b0 
…dd-response

fix #99
@petertheprocess
Fetch the latest roomlist before enter room action. fix #98
62c36c5
@petertheprocess
Merge pull request #100 from sopra-fs24-group-09/M3-check-roomlist-be…
5e9ce4d 
…fore-enter

M3 check roomlist before enter
@petertheprocess
If lose connection (network err or ws disconnected) with server, clea…
77a14c9 
…n all storage and alert user. fix #103
@petertheprocess
Merge pull request #104 from sopra-fs24-group-09/M3-lobby-request-exc…
bdaeeaf 
…eption-handle

Lobby requset exception handle
This was linked to issues Apr 26, 2024
If lose connection (network err or ws disconnected) with server, clean all storage and alert user. #103
Closed
After ws connection sucessed but the room enter action is rejected by backend, user should get alert and navigated back to lobby. #99
Closed
Word shows in the speaker's gaming page. #46
Closed
Countdown and hints shows on answerer players' page, when speaker is recording. #47
Closed
Once new audio is sent from backend, the page should imediatly show or update this audio. #67
Closed
Implement a button disabled based on the status for users to quit the room. #82
Closed
Implement a start button disabled based on the status for the room owner to start the game. #83
Closed
Prevent unsupported broswer play game. #94
Closed
Change ui and disabled conditions for buttons. #95
Closed
Fetch the latest roomlist before enter room action. #98
Closed
This was unlinked from issues Apr 26, 2024
After ws connection sucessed but the room enter action is rejected by backend, user should get alert and navigated back to lobby. #99
Closed
If lose connection (network err or ws disconnected) with server, clean all storage and alert user. #103
Closed
Prevent unsupported broswer play game. #94
Closed
Fetch the latest roomlist before enter room action. #98
Closed
@petertheprocess petertheprocess linked an issue Apr 26, 2024 that may be closed by this pull request
Implement a pop-up window with guidelines #41
Closed
@petertheprocess petertheprocess self-assigned this Apr 26, 2024
@petertheprocess petertheprocess added this to the Sprint 1 milestone Apr 26, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@petertheprocess petertheprocess merged commit b2b4e09 into dev Apr 26, 2024
2 of 3 checks passed
@petertheprocess petertheprocess deleted the M3-intergration-test branch May 24, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zihanltesla zihanltesla Awaiting requested review from zihanltesla

@Haaaan1 Haaaan1 Awaiting requested review from Haaaan1

@Zehao-Zhang Zehao-Zhang Awaiting requested review from Zehao-Zhang

@yixuan-zhou-uzh yixuan-zhou-uzh Awaiting requested review from yixuan-zhou-uzh

Assignees

@petertheprocess petertheprocess

Labels
None yet
Projects
None yet
Milestone
Sprint 1
5 participants
@petertheprocess @Haaaan1 @zihanltesla @Zehao-Zhang @yixuan-zhou-uzh