Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib: add tox data directory to gitignore #2536

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

SnoopJ
Copy link
Contributor

@SnoopJ SnoopJ commented Oct 31, 2023

Description

The tox configuration in contrib/ will store its working data (virtual environments, logs, scratch space) in contrib/.tox, which shows up in git status. This changeset adds that location to .gitignore (a brand new contrib/.gitignore for managing contrib files specifically) to avoid untracked file clutter for users (read as: @dgw) who opt into the tox workflow.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make lint and make test)
  • I have tested the functionality of the things this change touches

@SnoopJ SnoopJ added the Housekeeping Code cleanup, removal of deprecated stuff, etc. label Oct 31, 2023
@SnoopJ SnoopJ force-pushed the contrib/ignore-tox-dir branch from e8a478c to 14a2fc3 Compare October 31, 2023 16:57
@dgw dgw enabled auto-merge October 31, 2023 17:08
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it. Even checked git check-ignore for my contrib/.tox directory. Works a treat.

@dgw dgw merged commit 440122d into sopel-irc:master Oct 31, 2023
13 checks passed
@SnoopJ SnoopJ deleted the contrib/ignore-tox-dir branch October 31, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Housekeeping Code cleanup, removal of deprecated stuff, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants