Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeQL: restrict paths on which action should run #2534

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Conversation

dgw
Copy link
Member

@dgw dgw commented Oct 29, 2023

Saves us from burning GHA minutes (4-5 min/run) on CodeQL analysis when no files in the sopel/ directory were changed.

Should have done this in #2528 but alas, I forgot.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make lint and make test)
  • I have tested the functionality of the things this change touches
    • Whether the CodeQL workflow runs when I open the PR will be the test, lol
      • CodeQL workflow doesn't appear on the Checks tab for this PR; seems to have worked 🥳

Notes

No, unnecessary Actions runs don't cost the project anything, but since it's so easy to be nice and not waste even free resources on analyzing non-code changes, I think we might as well.

Thought about it, but can't skip the CI pipeline for unrelated changes because those checks are marked as required. They also finish in just a minute or two, vs. the 4-5 minutes (or longer) that CodeQL takes to run.

Saves us from burning GHA minutes (4-5 min/run) on CodeQL analysis when
no files in the `sopel/` directory were changed.
@dgw dgw added Build Housekeeping Code cleanup, removal of deprecated stuff, etc. labels Oct 29, 2023
@dgw dgw marked this pull request as ready for review October 29, 2023 07:20
@dgw dgw requested a review from a team October 29, 2023 07:20
@dgw dgw enabled auto-merge October 29, 2023 07:22
@dgw dgw merged commit abc9322 into master Oct 29, 2023
11 checks passed
@dgw dgw deleted the codeql-action-paths branch October 29, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Housekeeping Code cleanup, removal of deprecated stuff, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants