lifecycle: issue deprecation notices in pre-releases #2522
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changeset modifies the version check for deprecation warnings so that only the release segment of a version tag is used to check if a warning should be issued. For instance, currently a
@deprecation(warning_in="8.0")
will not warn in8.0.0.dev0
because the pre-release is considered to come before the 'final' release.@dgw mentions that this might make for noisy logs in some cases, but I'm of the opinion that if I am running
8.0.0.dev0
, I want to see deprecation warnings that will be current when8.0.0
is finalized, before that version is tagged. This is a concern for both core usage of in-the-future deprecated features, and for plugin authors who are checking their plugins against a coming release (although the latter is a softer concern).Closes #2308.
Checklist
make qa
(runsmake lint
andmake test
)