Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci, make: "lint" (flake8 & mypy) replace "quality" #2502

Merged
merged 2 commits into from
Aug 16, 2023

Commits on Aug 12, 2023

  1. ci, make: "lint" (flake8 & mypy) replace "quality"

    I know I did that, so I'm owning my mistake, and rename "make quality"
    by "make lint". A linter is something that checks your code for errors,
    and both flake8 and mypy are linters.
    
    There are now 2 new make commands:
    
    * make lint-style: perform any code style check (today: flake8 only),
      it could be used for a pylint check for example, or isort, or rst
      check, or anything that could help us with code style in the future
    * make lint-type: perform any type check (today: mypy only)
    
    The command `quality` is replaced by the command `lint`, which runs both
    `lint-style` and `lint-type`.
    
    Type check is now mandatory in CI, and the PR template has been updated
    accordingly.
    Exirel committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    62b439b View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Configuration menu
    Copy the full SHA
    6fa76f3 View commit details
    Browse the repository at this point in the history