-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sopel 8 upgrade guide #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sharing some long-overdue feedback, most of it authored in December for an earlier draft that was similar to this.
Even though I have some requested changes, I'm approving this as-is, because clearly none of my feedback is so important that it couldn't wait several months. At this point, our best feedback will probably come from users, and we just want to get 8.0 out the door.
@half-duplex Bunch of changes pushed up in response to your feedback 😸 |
The result of lengthy collaboration. Commit metadata does not *quite* reflect the actual authorship timeline... ;-) Co-authored-by: James <[email protected]> Co-authored-by: mal <[email protected]>
Seeing no further objections (feedback), I have started getting this ready to merge. Will most likely create a new PR to hold all of the 8.0-related updates and test integrating all the different parts (upgrade guide, updated submodule docs, updated redirects, etc.) before final merge. |
Current status: Trying to convince Netlify that it should actually show the deploy log so I have a chance to fix whatever went wrong after pulling in sopel-irc/sopel#2606 to test the new docs. It gets stuck like this and never loads the log: Edit: On a fresh branch that only touches
I will revert this branch to the known-working upgrade guide and continue debugging |
f9ba9e9
to
a74fa39
Compare
It's time that this branch had a PR, so other maintainers can give feedback on the upgrade guide ahead of release. Draft for now; goodness knows the history already needs cleanup, and it will need even more after review(s).