Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewValidator Changes #733

Merged
merged 29 commits into from
Jan 2, 2024
Merged

NewValidator Changes #733

merged 29 commits into from
Jan 2, 2024

Conversation

akshitad11
Copy link
Collaborator

Refactored NewValidator.java to work with Sootup.
Deleting CheckEscapingValidator.java and ReturnStatementsValidator.java.

Deleting CheckEscapingValidator.java and ReturnStatementsValidator.java.
@akshitad11 akshitad11 requested a review from kadirayk October 30, 2023 17:04
@swissiety
Copy link
Collaborator

please execute the maven fmt plugin to adhere to the projects code style

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 96 lines in your changes are missing coverage. Please review.

Comparison is base (129eeb7) 63.78% compared to head (3dd6d09) 63.38%.
Report is 7 commits behind head on develop.

Files Patch % Lines
...main/java/sootup/core/validation/NewValidator.java 0.00% 65 Missing ⚠️
.../bytecode/interceptors/JimpleSemanticsChecker.java 0.00% 12 Missing ⚠️
.../src/main/java/sootup/core/jimple/basic/Local.java 33.33% 1 Missing and 1 partial ⚠️
...java/sootup/core/validation/FieldRefValidator.java 0.00% 2 Missing ⚠️
...n/java/sootup/core/validation/LocalsValidator.java 0.00% 2 Missing ⚠️
...ava/sootup/core/validation/CheckInitValidator.java 0.00% 1 Missing ⚠️
...va/sootup/core/validation/CheckTypesValidator.java 0.00% 1 Missing ⚠️
...tup/core/validation/CheckVoidLocalesValidator.java 0.00% 1 Missing ⚠️
...p/core/validation/IdentityStatementsValidator.java 0.00% 1 Missing ⚠️
...java/sootup/core/validation/IdentityValidator.java 0.00% 1 Missing ⚠️
... and 8 more
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #733      +/-   ##
=============================================
- Coverage      63.78%   63.38%   -0.41%     
+ Complexity      3385     3376       -9     
=============================================
  Files            315      314       -1     
  Lines          15017    15074      +57     
  Branches        2534     2557      +23     
=============================================
- Hits            9579     9555      -24     
- Misses          4545     4626      +81     
  Partials         893      893              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

*/

import java.util.List;
import java.util.*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need the license headers, you can add your name too.

@kadirayk kadirayk merged commit bc6f0bc into develop Jan 2, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants