Optimize/asmmethodsource loop unroll remove necessity to reverse #722

swissiety · 2023-10-26T09:48:32Z

improves readability for humans as well

use array (assign entries from high index to low index) and Arrays.toList to remove the necessity of reversing the ArrayList after creation unify 2 ternary-ifs with equivalent condition to a single if invert inverted if condition

…he version with: List<Immediate> args as parameter instead

…ve_necessity_to_reverse # Conflicts: # sootup.java.bytecode/src/main/java/sootup/java/bytecode/frontend/AsmMethodSource.java

… init that will not be used if its empty

codecov · 2023-10-26T10:05:51Z

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (baa460f) 65.37% compared to head (5e7d922) 65.35%.
Report is 57 commits behind head on develop.

Additional details and impacted files

@@              Coverage Diff              @@
##             develop     #722      +/-   ##
=============================================
- Coverage      65.37%   65.35%   -0.02%     
+ Complexity      3408     3404       -4     
=============================================
  Files            313      313              
  Lines          14973    14979       +6     
  Branches        2524     2520       -4     
=============================================
+ Hits            9789     9790       +1     
- Misses          4294     4299       +5     
  Partials         890      890

Files	Coverage Δ
....core/src/main/java/sootup/core/jimple/Jimple.java	`87.23% <ø> (ø)`
...sootup/java/bytecode/frontend/AsmMethodSource.java	`71.95% <82.97%> (-0.27%)`	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

… 'performance' for the cost of 3 lines of code duplication

swissiety added 6 commits July 17, 2023 13:43

optimize:

c3fdbe6

use array (assign entries from high index to low index) and Arrays.toList to remove the necessity of reversing the ArrayList after creation unify 2 ternary-ifs with equivalent condition to a single if invert inverted if condition

deprecate methods: Jimple.new*Invoke(..., Immediate .. args) -> use t…

801bc94

…he version with: List<Immediate> args as parameter instead

Merge branch 'develop' into optimize/asmmethodsource_loop_unroll_remo…

4c43c27

…ve_necessity_to_reverse # Conflicts: # sootup.java.bytecode/src/main/java/sootup/java/bytecode/frontend/AsmMethodSource.java

fix missing import /merge leftover

985ea7e

optimize: merge ifs; flip ! condition; remove unnecessary empty array…

5e0f7d9

… init that will not be used if its empty

refactor: merge if

d163bcb

swissiety added 3 commits October 26, 2023 12:10

refactor: reduce repeated condition checks to improve readability and…

29cc210

… 'performance' for the cost of 3 lines of code duplication

same principle again

4327ee1

we can dodowhile

5e7d922

swissiety requested a review from stschott October 26, 2023 11:24

stschott approved these changes Oct 27, 2023

View reviewed changes

stschott merged commit 647da14 into develop Oct 27, 2023
8 checks passed

swissiety deleted the optimize/asmmethodsource_loop_unroll_remove_necessity_to_reverse branch November 8, 2023 12:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Optimize/asmmethodsource loop unroll remove necessity to reverse #722

Optimize/asmmethodsource loop unroll remove necessity to reverse #722

swissiety commented Oct 26, 2023 •

edited

Loading

codecov bot commented Oct 26, 2023 •

edited

Loading

Optimize/asmmethodsource loop unroll remove necessity to reverse #722

Optimize/asmmethodsource loop unroll remove necessity to reverse #722

Conversation

swissiety commented Oct 26, 2023 • edited Loading

codecov bot commented Oct 26, 2023 • edited Loading

Codecov Report

swissiety commented Oct 26, 2023 •

edited

Loading

codecov bot commented Oct 26, 2023 •

edited

Loading