investigate issue714

sootup.core/src/main/java/sootup/core/jimple/common/expr/JNewMultiArrayExpr.java

@@ -104,7 +104,7 @@ public ArrayType getBaseType() {
     return baseType;
   }
 
-  public Value getSize(@Nonnull int index) {
+  public Immediate getSize(@Nonnull int index) {
     return sizes.get(index);
   }
 

sootup.core/src/main/java/sootup/core/signatures/MethodSubSignature.java

@@ -85,6 +85,10 @@ public boolean equals(Object o) {
 
     MethodSubSignature that = (MethodSubSignature) o;
 
+    if (!super.equals(that)) {
+      return false;
+    }
+
     return Objects.equal(getParameterTypes(), that.getParameterTypes());
   }
 

sootup.java.bytecode/src/test/java/sootup/java/bytecode/bugs/Issue714Test.java

@@ -0,0 +1,117 @@
+package sootup.java.bytecode.bugs;
+
+import categories.Java9Test;
+import java.util.Collections;
+import java.util.Optional;
+import org.junit.Assert;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import sootup.core.graph.StmtGraph;
+import sootup.core.model.SootMethod;
+import sootup.core.signatures.MethodSignature;
+import sootup.core.util.DotExporter;
+import sootup.java.bytecode.inputlocation.JrtFileSystemAnalysisInputLocation;
+import sootup.java.core.JavaSootClass;
+import sootup.java.core.JavaSootMethod;
+import sootup.java.core.views.JavaModuleView;
+import sootup.java.core.views.JavaView;
+
+@Category(Java9Test.class)
+public class Issue714Test {
+
+  @Test
+  public void slow_localSplitter() {
+    // "jdk.internal.jimage.ImageStringsReader :: mutf8FromString will cause LocalSplitter not halt
+    // / comsume unreasonable time"
+
+    JavaModuleView view =
+        new JavaModuleView(
+            Collections.emptyList(),
+            Collections.singletonList(new JrtFileSystemAnalysisInputLocation()));
+
+    final MethodSignature methodSignature =
+        view.getIdentifierFactory()
+            .parseMethodSignature(
+                "<java.base/jdk.internal.jimage.ImageStringsReader: byte[] mutf8FromString(java.lang.String)>");
+    final Optional<JavaSootClass> classOpt = view.getClass(methodSignature.getDeclClassType());
+    Assert.assertTrue(methodSignature.getDeclClassType() + " not found", classOpt.isPresent());
+
+    final Optional<? extends SootMethod> methodOpt = view.getMethod(methodSignature);
+    Assert.assertTrue(methodOpt.isPresent());
+
+    final StmtGraph<?> stmtGraph = methodOpt.get().getBody().getStmtGraph();
+
+    System.out.println(DotExporter.createUrlToWebeditor(stmtGraph));
+    System.out.println(stmtGraph);
+  }
+
+  @Test
+  public void slow_TypeAssigner() {
+    // 6s not fast but sounds reasonable..
+
+    //     java.lang.Character$UnicodeScript :: <clinit> will cause TypeAssigner not halt / comsume
+    // unreasonable time. It seems that the real problem occurs in the LocalNameStandardizer.
+
+    JavaView view =
+        new JavaModuleView(
+            Collections.emptyList(),
+            Collections.singletonList(new JrtFileSystemAnalysisInputLocation()));
+
+    // https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/Character.UnicodeScript.html
+    final MethodSignature methodSignature =
+        view.getIdentifierFactory()
+            .getMethodSignature(
+                "java.base/java.lang.Character$UnicodeScript",
+                "<clinit>",
+                "void",
+                Collections.emptyList());
+    final Optional<JavaSootClass> classOpt = view.getClass(methodSignature.getDeclClassType());
+    Assert.assertTrue(methodSignature.getDeclClassType() + " not found", classOpt.isPresent());
+
+    final Optional<? extends SootMethod> methodOpt = view.getMethod(methodSignature);
+    Assert.assertTrue(methodOpt.isPresent());
+
+    final StmtGraph<?> stmtGraph = methodOpt.get().getBody().getStmtGraph();
+
+    System.out.println(DotExporter.createUrlToWebeditor(stmtGraph));
+    System.out.println(stmtGraph);
+  }
+
+  @Test
+  public void bloated_AsmMethodSource_worklist() {
+    //    sun.jvm.hotspot.ui.classbrowser.HTMLGenerator :: genHTMLListForFields, with desc
+    // (Lsun/jvm/hotspot/oops/InstanceKlass;)Ljava/lang/String;, will cause AsmMethodSource ::
+    // convert not halt / comsume unreasonable time. It worth noting that the worklist will be full
+    // of elements, even through the length of instructions list is just 172. Please refer to the
+    // attached screenshot for more details.
+
+    JavaView view =
+        new JavaModuleView(
+            Collections.emptyList(),
+            Collections.singletonList(new JrtFileSystemAnalysisInputLocation()));
+
+    // https://code.yawk.at/java/11/jdk.hotspot.agent/sun/jvm/hotspot/ui/classbrowser/HTMLGenerator.java#sun.jvm.hotspot.ui.classbrowser.HTMLGenerator%23genHTMLListForFields(sun.jvm.hotspot.oops.InstanceKlass)
+    final MethodSignature methodSignature =
+        view.getIdentifierFactory()
+            .getMethodSignature(
+                "jdk.hotspot.agent/sun.jvm.hotspot.ui.classbrowser.HTMLGenerator",
+                "genHTMLListForFields",
+                "java.lang.String",
+                Collections.singletonList("jdk.hotspot.agent/sun.jvm.hotspot.oops.InstanceKlass"));
+
+    final Optional<JavaSootClass> classOpt = view.getClass(methodSignature.getDeclClassType());
+    Assert.assertTrue(methodSignature.getDeclClassType() + " not found", classOpt.isPresent());
+
+    for (JavaSootMethod javaSootMethod : classOpt.get().getMethods()) {
+      System.out.println(javaSootMethod);
+    }
+
+    final Optional<? extends SootMethod> methodOpt = view.getMethod(methodSignature);
+    Assert.assertTrue(methodOpt.isPresent());
+
+    final StmtGraph<?> stmtGraph = methodOpt.get().getBody().getStmtGraph();
+
+    System.out.println(DotExporter.createUrlToWebeditor(stmtGraph));
+    System.out.println(stmtGraph);
+  }
+}