Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing Local assignments /Bytecodefrontend #706

Closed
wants to merge 6 commits into from
Closed

fix missing Local assignments /Bytecodefrontend #706

wants to merge 6 commits into from

Conversation

swissiety
Copy link
Collaborator

@swissiety swissiety commented Oct 9, 2023 •
edited
Loading

  • added compilation unit classtype/sootup configuration sanity check in the bytecodefrontend
  • fixed missing assignments for the test input
  • don't fail Jimple testcases
  • check if the other additionally inserted JAssignStmts need it as well
  • check against generated jimple from old soot (without BodyTransformers) ->are there missing assignments as well?

closes #698

@swissiety swissiety marked this pull request as draft October 9, 2023 11:38
@swissiety
Copy link
Collaborator Author

expected Stmt is generated at some point but gets replaced afterwards.. maybe it happens in mergeIn() / updateUsages()

@swissiety swissiety changed the title fix missing Local assignments fix missing Local assignments /Bytecodefrontend Oct 9, 2023
@Liyw979
Copy link
Contributor

Liyw979 commented Nov 1, 2023

Is there a way to deal with this issue temporally? I am seeing this quite often.

@swissiety
Copy link
Collaborator Author

unfortunately the area where this bug arises is quite essential - but a colleague is actively working on fixing that Issue!

@Timbals
Copy link
Contributor

Timbals commented Nov 3, 2023

I think this PR can be closed. The fix will be implemented as part of #742 instead.

@swissiety swissiety closed this Nov 3, 2023
@swissiety swissiety deleted the fix/#698_missing_TableName branch November 8, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undefined variable but used
3 participants
@swissiety @Liyw979 @Timbals