port intraprocedural analysis and fix the long tail.. #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, as it is used with another instance directly in the ClassSources, too
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #664 +/- ##
=============================================
- Coverage 65.37% 64.05% -1.33%
- Complexity 3408 3430 +22
=============================================
Files 313 317 +4
Lines 14973 15385 +412
Branches 2524 2613 +89
=============================================
+ Hits 9789 9855 +66
- Misses 4294 4622 +328
- Partials 890 908 +18
☔ View full report in Codecov by Sentry. |
…types and moving fields to subclasses to remove necessity of internal casts
… denotes Values that can be used on the left handside of an Assignment - eliminates another runtime check for allowed variable ie leftOp types in JAssignStmt
and i hope its only the (already) wrong order that makes a leftover of the $stack3 which should be the r0 as well.. |
struce2
reviewed
Sep 26, 2023
|
When I use commit
|
please share the complete StackTrace. |
When enable when disable the url is too long, so i deleted something like here is classes file sootUp setup |
|
disable |
- doesn't always remove all edges when removing at the tail - returns a boolean indicating if an edge was removed
…DeadAssignmentEliminator`
Fix some issues in `MutableBlockStmtGraph`
… non-FallsThroughStmt.. now: giving the modifier more power over branching successors
|
@struce2 can you check if the error still occurs with your input? |
Works fine without error |
…rs can not be added as they are FallsThroughStmt nor BranchingStmt
# Conflicts: # sootup.java.bytecode/src/test/java/sootup/java/bytecode/Soot1577.java # sootup.java.bytecode/src/test/java/sootup/java/bytecode/minimaltestsuite/java11/TypeInferenceLambdaTest.java # sootup.java.bytecode/src/test/java/sootup/java/bytecode/minimaltestsuite/java8/MethodAcceptingLamExprTest.java
JonasKlauke
approved these changes
Oct 24, 2023
sootup.core/src/main/java/sootup/core/jimple/common/stmt/Stmt.java
Outdated
Show resolved
Hide resolved
....java.bytecode/src/main/java/sootup/java/bytecode/interceptors/BytecodeBodyInterceptors.java
Outdated
Show resolved
Hide resolved
...p.java.bytecode/src/main/java/sootup/java/bytecode/interceptors/ConditionalBranchFolder.java
Outdated
Show resolved
Hide resolved
sootup.java.bytecode/src/test/java/sootup/java/bytecode/interceptors/AggregatorTest.java
Outdated
Show resolved
Hide resolved
# Conflicts: # sootup.java.bytecode/src/test/java/sootup/java/bytecode/interceptors/AggregatorTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for deca and other more elaborated BodyInterceptors that were added to soot in the meantime.
FallsThroughStmtand makeStmt,BranchingStmtand newFallsThroughStmtInterfacesMutableStmtGraph.insertBefore(...)fix LocalSplitter - seems it starts already here - (or better port the newer/improved one in Soot?) as it does not (replace all former Local references in Stmts?) anyway it creates a precondition in a way that the DeadAssignmentEliminator wants to remove stmts which it does not when the LocalSplitter is not called. Which means it has leftovers in the StmtGraph or does something else wrong. Have a look at the newest LocalSplitter in Soot before fixing the current port as it seems to be a more precise algorithm.couldnt reproduce this assumption - deadassignmenteliminator failed in the mentioned commit already on its ownStmtgraphedges which gives the developer the necessary power to modify the correct successor of a BranchingStmt - putEdge(FallsThroughStmt, Stmt) works like before and putEdge(Stmt, int, Stmt) needs a successorIdx according to the semantics of the respective BranchingStmt.putEdge(Stmt, int, Stmt)all Stmts that have no successor like return/throw can't be used as a first Argument as they would fail already at compiletime.closes #667, #692