Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified CopyPropagator to function as expected #1022

Conversation

sahilagichani14
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@swissiety swissiety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice finding!

Copy link
Contributor

Documentation Preview.

@sahilagichani14
Copy link
Collaborator Author

https://arxiv.org/pdf/2207.03894,
Definition 3[Copy Propagation]: The use of a variable y in the statement z=x+y occurring at a point
p can be replaced by a variable w if every path from the entry node to point p contains the same
definition y=w, for the variable y, and after the definition prior to reaching p, there is no redefinition to
the variable y and no redefinition to the variable w.

@sahilagichani14 sahilagichani14 force-pushed the 1021-bug-copypropagator-not-propagating-constant-to-sout-binary-expressions-if-condition branch from 52e2ba3 to dea9d98 Compare August 16, 2024 15:22
@sahilagichani14 sahilagichani14 self-assigned this Aug 16, 2024
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 71.90%. Comparing base (199ebe8) to head (f373fd5).
Report is 1 commits behind head on develop.

Files Patch % Lines
.../sootup/java/core/interceptors/CopyPropagator.java 83.33% 2 Missing and 4 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1022      +/-   ##
=============================================
- Coverage      71.95%   71.90%   -0.06%     
+ Complexity      4454     4453       -1     
=============================================
  Files            367      367              
  Lines          16377    16403      +26     
  Branches        2740     2748       +8     
=============================================
+ Hits           11784    11794      +10     
- Misses          3688     3694       +6     
- Partials         905      915      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…onstant-to-sout-binary-expressions-if-condition
Copy link
Collaborator

@swissiety swissiety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please adapt the exception type and we are good to go

@swissiety swissiety force-pushed the 1021-bug-copypropagator-not-propagating-constant-to-sout-binary-expressions-if-condition branch from a04918c to 3b44112 Compare August 19, 2024 09:05
@swissiety swissiety merged commit 62a35b6 into develop Aug 19, 2024
8 checks passed
@swissiety swissiety deleted the 1021-bug-copypropagator-not-propagating-constant-to-sout-binary-expressions-if-condition branch August 19, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: CopyPropagator not Propagating Constant to sout, binary expressions, if condition
2 participants