Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add cpg tests #1009

Merged
merged 8 commits into from
Aug 13, 2024
Merged

Feature/add cpg tests #1009

merged 8 commits into from
Aug 13, 2024

Conversation

michaelyoukeim
Copy link
Collaborator

@michaelyoukeim michaelyoukeim commented Aug 7, 2024

  • Fixed the failing tests in the CPG module
  • Added a documentation

closes #1002

@michaelyoukeim michaelyoukeim self-assigned this Aug 7, 2024
@michaelyoukeim michaelyoukeim added the enhancement New feature or request label Aug 7, 2024
Copy link
Contributor

github-actions bot commented Aug 7, 2024

Documentation Preview.

@michaelyoukeim michaelyoukeim marked this pull request as ready for review August 7, 2024 14:09
@stschott
Copy link
Collaborator

stschott commented Aug 7, 2024

Closes #1002

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.18%. Comparing base (2336e6e) to head (269a2e7).
Report is 138 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #1009       +/-   ##
==============================================
- Coverage      70.30%   43.18%   -27.13%     
- Complexity      4203     4453      +250     
==============================================
  Files            317      587      +270     
  Lines          15736    27313    +11577     
  Branches        2701     4466     +1765     
==============================================
+ Hits           11063    11794      +731     
- Misses          3806    14612    +10806     
- Partials         867      907       +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@swissiety swissiety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@swissiety
Copy link
Collaborator

coverage went down a lot.. maybe exclude qilin from test reports at the moment - ill add a comment to the qilin+tests issue

sootup.report/pom.xml Outdated Show resolved Hide resolved
@michaelyoukeim
Copy link
Collaborator Author

@swissiety Thanks! I'll merge with this status.

@michaelyoukeim michaelyoukeim merged commit f8a6da8 into develop Aug 13, 2024
7 of 8 checks passed
@michaelyoukeim michaelyoukeim deleted the feature/addCpgTests branch August 13, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants