Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POC of replacing
discovery_mode
setting with sneakily stashingHost
header in theweb::uri
values returned bynmos::details::resolve_service
and using this in aweb::http::http_pipeline_stage
.Resolves #357
Using the user info in this way is a bit icky. But the other option is to make lots of places that pass
web::uri
around pass a pair of the URI with theHost
header. This way has the side effect of making the values in the settings look something like this whether doing HTTP or HTTPS:If anyone is relying on that property e.g. to populate UI, that would be an unexpected change. :-/
(However, it does also allow the existing
registry_address
setting to be populated in the same way, and that just works too.)