Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General tidy up #361

Merged
merged 5 commits into from
Jan 8, 2024
Merged

General tidy up #361

merged 5 commits into from
Jan 8, 2024

Conversation

lo-simon
Copy link
Contributor

@lo-simon lo-simon commented Jan 6, 2024

  • Remove unused function
  • Bump json-schema-validator to v2.3.0 and nlohmann_json to v3.11.3
  • Disable msvc-dev-cmd for non-windows OS to prevent node20 error on ubuntu-14.04 runner

@lo-simon lo-simon changed the title IS-10 tidy up General tidy up Jan 8, 2024
jonathan-r-thorpe
jonathan-r-thorpe approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@jonathan-r-thorpe jonathan-r-thorpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathan-r-thorpe jonathan-r-thorpe merged commit 85d5443 into sony:master Jan 8, 2024
11 checks passed
@jonathan-r-thorpe jonathan-r-thorpe deleted the general_tidy_up branch January 8, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-r-thorpe jonathan-r-thorpe jonathan-r-thorpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lo-simon @jonathan-r-thorpe