Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to respect to best practice of redux, remove redundant code. #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lockys
Copy link

@lockys lockys commented Mar 28, 2021

Hi,

  1. I removed the redundant code onCreate in Header.js
  2. move ID generation code to action creator to respect the best practice of redux.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant