[vslib] Add support for PoE feature #1404
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
kcudnik
reviewed
Jul 19, 2024
kcudnik
reviewed
Jul 19, 2024
kcudnik
reviewed
Jul 19, 2024
kcudnik
reviewed
Jul 19, 2024
Add SwitchPoe to vslib Add a python script to spawn the PoE syncd process Signed-off-by: Serhiy Boiko <[email protected]>
|
Please write some unittests to satisfy code coverage |
SAI_SWITCH_ATTR_POE_DEVICE_LIST is not readonly, so it is not handled by refresh_read_only(). Signed-off-by: Serhiy Boiko <[email protected]>
Signed-off-by: Serhiy Boiko <[email protected]>
Signed-off-by: Serhiy Boiko <[email protected]>
praveenraja1
reviewed
Aug 5, 2024
| { | ||
| attr.id = SAI_POE_PORT_ATTR_POWER_LIMIT; | ||
| attr.value.u32 = 0; | ||
| CHECK_STATUS(set(SAI_OBJECT_TYPE_POE_PORT, object_id, &attr)); |
There was a problem hiding this comment.
This is just for my understanding,
I was under the impression that this code would eventually interact with PoE controller, could you point me to code where that happens.
There was a problem hiding this comment.
This is an implementation for the virtual switch. There is no poe cotroller to communicate with, so we only report dummy data.
When vendors are writing sai for their physical devices and handling SAI_POE_* attributes then they will be communicating with the poe controller.
kcudnik
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PoE virtual switch implementation to vslib
Add a python script to spawn the PoE syncd process