feat: add parallel modes file to pipeline #15719
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerry-lee
reviewed
Nov 25, 2024
| @@ -119,6 +119,10 @@ parameters: | |||
| type: string | |||
| default: "" | |||
|
|
|||
| - name: PARALLEL_MODES_FILE | |||
| type: string | |||
| default: "default.json" | |||
There was a problem hiding this comment.
It is recommended to leave this parameter empty, as parallel run is disabled by default and we already have a default value in test_plan.py and elastictest. Additionally, consider adding a comment for clarification if necessary.
There was a problem hiding this comment.
Good idea! Let me fix this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Add parallel modes file option to pipeline so users can customize the parallel modes by using their own file in the
test_parallel_modes/folder.Summary:
Fixes # (issue) Microsoft ADO 29867650
Type of change
Back port request
Approach
What is the motivation for this PR?
We want users to be able to customize the parallel modes file, so we added the parallel modes file option to the pipeline.
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation