Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed swss feature name for test_lldp_neighbor_post_orchagent_reboot #15715

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anamehra
Copy link
Contributor

@anamehra anamehra commented Nov 23, 2024

Signed-off-by: Anand Mehra [email protected]

Description of PR

Summary:
Fixes # #14689

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

The test test_lldp_neighbor_post_orchagent_reboot fails on multi-asic system. The test tries to disable autorestart feature for swss by using the namespace container name, e.g., swss0, swss1, etc

For config feature autorestart disable, it needs to use 'swss' as global feature name

How did you do it?

Changed code to use 'swss' as feature name without using namespace id

How did you verify/test it?

run sonic-mgmt test_lldp.py

------------------------------------------------------------------------------------------------------------------- live log sessionfinish --------------------------------------------------------------------------------------------------------------------
15:30:20 __init__.pytest_terminal_summary         L0067 INFO   | Can not get Allure report URL. Please check logs
=================================================================================================================== short test summary info ===================================================================================================================
PASSED lldp/test_lldp.py::test_lldp_neighbor_post_orchagent_reboot[sfd-t2-lc0-0]
PASSED lldp/test_lldp.py::test_lldp_neighbor_post_orchagent_reboot[sfd-t2-lc0-1]
PASSED lldp/test_lldp.py::test_lldp_neighbor_post_orchagent_reboot[sfd-t2-lc0-2]
========================================================================================================== 3 passed, 1 warning in 472.45s (0:07:52) ===========================================================================================================```

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: Anand Mehra [email protected]
@anamehra
Copy link
Contributor Author

Hi @arlakshm , @SuvarnaMeenakshi , please review. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants