Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Enable sonic-restapi build in PR validation. #17397

Merged
merged 2 commits into from
Dec 15, 2023
Merged

[ci] Enable sonic-restapi build in PR validation. #17397

merged 2 commits into from
Dec 15, 2023

Conversation

liushilongbuaa
Copy link
Contributor

@liushilongbuaa liushilongbuaa commented Dec 4, 2023 •
edited
Loading

Why I did it

Enable sonic-restapi build in two platform to avoid build break on restapi target.

Work item tracking
  • Microsoft ADO (number only): 26048426

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@liushilongbuaa liushilongbuaa marked this pull request as ready for review December 4, 2023 07:29
xumia
xumia approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@xumia xumia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liushilongbuaa
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liushilongbuaa
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liushilongbuaa
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

xumia
xumia approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@xumia xumia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xumia xumia merged commit 2532661 into sonic-net:master Dec 15, 2023
20 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request May 23, 2024
@liushilongbuaa @mssonicbld
[ci] Enable sonic-restapi build in PR validation. (sonic-net#17397)
48974a1 
Why I did it
Enable sonic-restapi build in two platform to avoid build break on restapi target.

Work item tracking
Microsoft ADO (number only): 26048426
How I did it
How to verify it
@mssonicbld mssonicbld mentioned this pull request May 23, 2024
Merged
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #19051

@mssonicbld
Copy link
Collaborator

@liushilongbuaa cherry pick PR didn't pass PR checker. Please check!!!
#19051

1 similar comment
@mssonicbld
Copy link
Collaborator

@liushilongbuaa cherry pick PR didn't pass PR checker. Please check!!!
#19051

@liushilongbuaa
Copy link
Contributor Author

@liushilongbuaa cherry pick PR didn't pass PR checker. Please check!!!#19051

Need to wait for PR cherry pick: sonic-net/sonic-restapi#150

@mssonicbld
Copy link
Collaborator

@liushilongbuaa cherry pick PR didn't pass PR checker. Please check!!!
#19051

@mssonicbld
Copy link
Collaborator

@liushilongbuaa cherry pick PR didn't pass PR checker. Please check!!!
#19051

1 similar comment
@mssonicbld
Copy link
Collaborator

@liushilongbuaa cherry pick PR didn't pass PR checker. Please check!!!
#19051

mssonicbld pushed a commit that referenced this pull request Jun 3, 2024
@liushilongbuaa @mssonicbld
[ci] Enable sonic-restapi build in PR validation. (#17397)
0e17142 
Why I did it
Enable sonic-restapi build in two platform to avoid build break on restapi target.

Work item tracking
Microsoft ADO (number only): 26048426
How I did it
How to verify it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xumia xumia xumia approved these changes

@qiluo-msft qiluo-msft Awaiting requested review from qiluo-msft qiluo-msft is a code owner

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

Assignees
No one assigned
Labels
Approved for 202311 Branch ci Included in 202311 Branch Request for 202311 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liushilongbuaa @mssonicbld @xumia @yxieca