Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue and improved network performance and added loader etc.. #182

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

rjoydip-zz
Copy link

This PR contains below points.

Description

  • fix(warning): Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function
  • fix(styled-component): To resolve this only create new Styled Components outside of any render method and function component
  • improved(rendering): Very slow network rendering (Very slow network rendering almende/vis#3187)
  • fix(state/travel): Error: Array index '-1' has to be an integer
  • fix(travel:filter): TypeError: Cannot read property 'forEach' of undefined
  • feat: loader functionality added
  • network cluster performance improved
  • memory leaking issues fixed some of the cases

Note: Loader designer is very much basic. Fell free to improve loader design after merged the PR.

…onent. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function fix(styled-component): To resolve this only create new Styled Components outside of any render method and function component improved(rendering): Very slow network rendering (almende/vis#3187)
@vercel
Copy link

vercel bot commented Mar 31, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/someshkar/covid19india-network/jasbjg0wz
✅ Preview: https://covid19india-network-git-fork-rjoydip-patch-2.someshkar.now.sh

@sibeshkar
Copy link
Collaborator

Thanks for the fixes. the extra squigliness in the edges seems to be destroying any performance optimization you made. Possible to fix? Also needs a better loader, that can be located at the top left. Thanks :)

…improved due to svg use refactor(img): image folder refactor
@rjoydip-zz
Copy link
Author

rjoydip-zz commented Apr 1, 2020

@sibeshkar

the extra squigliness in the edges seems to be destroying any performance optimization you made
Fixed. But changed all png logos to svg for better rendering. Also changed others logo

  • Images are taken from flaticon
  • Changed those gradient colored images (if required)
  • Loader placed on left top but the not responsive

Note: For further performance improvement and better resource loading you have to merge #171 PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants