[13.0][IMP] logistics_planning_*: adds hook and unhook logistics with account move line #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalonsod
reviewed
Dec 4, 2024
logistics_planning_invoicing/wizards/logistics_schedule_existing_account_move_wizard.py
Outdated
Show resolved
Hide resolved
ChristianSantamaria
force-pushed
the
13.0-imp-logistics_planning-account_move_line
branch
from
0cd25e7 to
c274a48
Compare
…isting account move
ChristianSantamaria
force-pushed
the
13.0-imp-logistics_planning-account_move_line
branch
from
c274a48 to
7e4d271
Compare
|
@dalonsod can u review this? |
|
Not sure if current implementation for sales and purchase addons will work when analytic account is not filled in origin (an unexpected error could be raised, looking for |
dalonsod
reviewed
Dec 9, 2024
| product_id = fields.Many2one('product.product', related='logistics_schedule_id.product_id') | ||
| carrier_id = fields.Many2one('res.partner', related='logistics_schedule_id.carrier_id') | ||
| invoice_line_id = fields.Many2one('account.move.line', string="Invoice Line") | ||
| domain_invoice_line_id = fields.Many2many('account.move.line', compute='_compute_domain_invoice_line_id') |
There was a problem hiding this comment.
Better naming:
Suggested change
| domain_invoice_line_id = fields.Many2many('account.move.line', compute='_compute_domain_invoice_line_id') | |
| domain_invoice_line_ids = fields.Many2many('account.move.line', compute='_compute_domain_invoice_line_ids') |
dalonsod
reviewed
Dec 9, 2024
| product_id = self.logistics_schedule_id._get_invoice_product() | ||
| if not product_id: | ||
| raise ValidationError(_("It is necessary to configure the default products of the logistics planning")) | ||
| return [('move_id.partner_id', '=', self.carrier_id.id), ('product_id', '=', product_id.id)] |
There was a problem hiding this comment.
I miss a default condition: only select those move lines that actually are invoice lines (see https://github.com/odoo/odoo/blob/4cc086d330b73514fbc64a7fcf22d8a7a9f1b691/addons/account/models/account_move.py#L216)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds hook and unhook logistics with account move line