Feature/ae 2317 add UI representation for new states #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful in tests
This is needed when the todistus can't be deleted after its expiration if there is still a valvonta that has to be kept for 2 years
There is still a potential problem that now all of energiatodistukset that have tila_id are repetedly set to tila_id 7 until their valvonta is old enough
The other one has recent oikeellisuuden valvonta
Still sees vanhentunut
Paakayttaja sees destroyed energiatodistukset but cant access them Paakayttaja sees expired energiatodistukset and can access them Laatija sees expired energiatodistukset and can access them Laatija can not see destroyed energiatodistukset
solita-juhohaa
force-pushed
the
feature/AE-2317-add-ui-representation-for-new-states
branch
from
50a15f0 to
a7140c7
Compare
For a more robust system one could build an endpoint that would tell which tasks the backend is currently running but it is probably too much work at this point.
solita-juhohaa
force-pushed
the
feature/AE-2317-add-ui-representation-for-new-states
branch
from
7ebab7a to
e89b546
Compare
…red energiatodistukset There might be some problem with the e2e configuration as the sites layout is somehow broken in the cypress tests but it might also be due to running the tests with Electron (only thing I can use with WSL). This is sufficient to test the functionality of the site though.
solita-juhohaa
force-pushed
the
feature/AE-2317-add-ui-representation-for-new-states
branch
2 times, most recently
from
3c06b2d to
f989321
Compare
solita-juhohaa
force-pushed
the
feature/AE-2317-add-ui-representation-for-new-states
branch
from
f989321 to
4ed9b4f
Compare
solita-juhohaa
commented
Oct 29, 2024
etp-core/etp-backend/src/main/clj/solita/etp/service/energiatodistus_destruction.clj
Outdated
Show resolved
Hide resolved
solita-juhohaa
commented
Oct 29, 2024
etp-core/etp-backend/src/main/clj/solita/etp/service/energiatodistus_destruction.clj
Outdated
Show resolved
Hide resolved
solita-juhohaa
commented
Oct 29, 2024
etp-core/etp-backend/src/main/sql/solita/etp/db/energiatodistus-destruction.sql
Show resolved
Hide resolved
The expired todistukset are just added to the test data
muep
approved these changes
Oct 29, 2024
solita-juhohaa
force-pushed
the
feature/AE-2317-add-ui-representation-for-new-states
branch
from
bcc4b52 to
3f625e7
Compare
solita-juhohaa
deleted the
feature/AE-2317-add-ui-representation-for-new-states
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.