Feature/ae 2274 viestit removal #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a based on energiatodistus-id
I have chosen to encapsulate all of the destruction logic in one namespace. I don't know if it is a good choice as I could also just add the functionality to destroy anything in their respective namespaces but as I find those functions to be somewhat dangerous I think encapsulating the destruction in just a single namespace is safer and therefore I need to expose this function.
When checking for existence the invoke function logged an error even though file-exists? expects the error to be thrown and therefore it's not an error in this case.
The outermost resources need to be deleted first
There is a possible problem that is handled in `check-oikeellisuuden-valvonta-viestiketjut` for now by just logging out an error if it happens. There are foreign key reference chain viestiketju->vo_toimenpide->energiatodistus and viestiketju->energiatodistus which could possibly cause problems as viestiketju can reference energiatodistus and a toimenpide that references different energiatodistus.
solita-juhohaa
force-pushed
the
feature/AE-2274-viestit-removal
branch
from
a6bbfaa to
9ae97fa
Compare
…to be done separately
…stus and use public api instead
…ame pattern as others
solita-juhohaa
force-pushed
the
feature/AE-2274-viestit-removal
branch
from
ccbbe8e to
59f8710
Compare
…t does not exist when destroying energiatodistus
solita-juhohaa
commented
Oct 16, 2024
solita-juhohaa
commented
Oct 16, 2024
| from vo_toimenpide | ||
| group by energiatodistus_id) latest_toimenpide | ||
| on energiatodistus.id = latest_toimenpide.energiatodistus_id | ||
| where voimassaolo_paattymisaika < current_date |
There was a problem hiding this comment.
Tässä voi olla ongelma, koska current_date saattaa antaa jo huomisen päivän, koska se ei välttämättä ole sidottu suomen aikavyöhykkeeseen
solita-juhohaa
commented
Oct 16, 2024
etp-core/etp-backend/src/main/sql/solita/etp/db/energiatodistus-destruction.sql
Outdated
Show resolved
Hide resolved
solita-juhohaa
commented
Oct 16, 2024
etp-core/etp-backend/src/main/clj/solita/etp/service/energiatodistus_destruction.clj
Outdated
Show resolved
Hide resolved
muep
approved these changes
Oct 16, 2024
solita-juhohaa
force-pushed
the
feature/AE-2274-viestit-removal
branch
from
b429bf5 to
8dbf9b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.